Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled filestore_csi_driver option for autopilot-cluster #1477

Conversation

butterthon-dev
Copy link

This option appears to have been added in #1166.
However, for some reason it was not enabled on the autopilot cluster, so I have fixed it so that it can be enabled.
Currently it appears to be possible to use Filestore CSI in an Autopilot cluster.
see: https://cloud.google.com/kubernetes-engine/docs/tutorials/stateful-workload?hl=ja

@comment-bot-dev
Copy link

@butterthon-dev
Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @butterthon-dev
It looks like the provider still does not support this. Could you file a provider issue to fix this first?

https://github.com/hashicorp/terraform-provider-google/blob/d2ea6580ef848edd94862d13ab7cddcb162df904/google/resource_container_cluster.go#L297-L304

From test:

       
       Error: Conflicting configuration arguments
       
         with module.example.module.gke.google_container_cluster.primary,
         on ../../../modules/beta-autopilot-private-cluster/cluster.tf line 113, in resource "google_container_cluster" "primary":
        113:     gcp_filestore_csi_driver_config {
       
       "addons_config.0.gcp_filestore_csi_driver_config": conflicts with
       enable_autopilot
       ```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants