-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial_node_count variable for scaling the default node pool #149
Add initial_node_count variable for scaling the default node pool #149
Conversation
@ctrox Is your intention to use the default node pool? We encourage explicitly passing the node pools you wish to use (via the node_pools argument on this module) and instead deleting the default node pool. |
@morgante I actually want to set the initial node count to implement this workaround. But if someone really wants to use the default node pool we would need to have a lot more configuration options available, so I think this one parameter does not make it likely for someone to actually use it. |
@ctrox Got it, that use case makes sense. Could we potentially compute a realistic initial_node_count based on the node_pool configs provided? Maybe you could share your expected configuration? |
@morgante It might be a bit hard to compute it with Terraform 0.11 but essentially it would be just adding the |
Hi @ctrox. Can you please move your implementation to the equivalent files in the |
@aaron-lane Totally missed that, sorry! Updated my branch accordingly. |
…de-count Add initial_node_count variable for scaling the default node pool
Adds a variable to be able to configure the number of nodes in the default node pool. It defaults to 0 so it should not change existing behaviour.