feat!: Add option to pass resource_labels to NP
#1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
reviewed
Dec 28, 2022
There was a problem hiding this comment.
Thanks for the PR @eyalzek
Let's also bump the min provider versions to 4.45.0 https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/versions.tf.tmpl
For configuring resource labels on a per node pool basis. Bump minimum provider version to 4.45.0. Fixes terraform-google-modules#1507
eyalzek
force-pushed
the
feature/node_pool_resource_labels
branch
from
00e6de7
to
949fb4d
Compare
bharathkkb
changed the title
resource_labels to NPresource_labels to NP
bharathkkb
approved these changes
Dec 29, 2022
|
@eyalzek |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…odules#1508) Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For configuring resource labels on a per node pool basis.
Fixes #1507