Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid TGP v4.49.0 for asm #1537

Merged
merged 13 commits into from
Feb 1, 2023

Conversation

jonchen727
Copy link
Contributor

Fixes the issue presented in #1533 for the ASM module which also relies on the google_container_cluster data provider.

@jonchen727 jonchen727 requested review from a team, Jberlinsky and ericyz as code owners January 20, 2023 16:29
@google-cla
Copy link

google-cla bot commented Jan 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

modules/asm/versions.tf Outdated Show resolved Hide resolved
jonchen727 and others added 8 commits January 26, 2023 18:29
…ation-toolkit/infra/blueprint-test to v0.4.1 (terraform-google-modules#1534)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…in /test/integration (terraform-google-modules#1538)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ules#1498)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@comment-bot-dev
Copy link

@jonchen727
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit 5d3d54e into terraform-google-modules:master Feb 1, 2023
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants