fix: nodepool autoscaling vars avail in GKE 1.24.1 result in conflicts. Change default behavior to null

[Aurelian-Shuttleworth]

Changes introduced in feat: add nodepool autoscaling vars avail in GKE 1.24.1 result in conflicts when using total limits.

Currently, google_container_node_pool resource states that total and per zone limits can't be used together.

This change removes the default behaviour where min and max are provided by default if autoscaling is enabled.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[comment-bot-dev]

@Aurelian-Shuttleworth
Thanks for the PR! 🚀
✅ Lint checks have passed.

[apeabody]

Thanks for the contribution @Aurelian-Shuttleworth, here is the int check error message:

Error: error creating NodePool: googleapi: Error 400: Node_pool_autoscaling.max_node_count and node_pool_autoscaling.total_max_node_count cannot be both set to zero., badRequest

  with module.example.module.gke.google_container_node_pool.pools["default-node-pool"],
  on ../../../modules/private-cluster/cluster.tf line 383, in resource "google_container_node_pool" "pools":
 383: resource "google_container_node_pool" "pools" {
}
    apply.go:34: 
        	Error Trace:	/workspace/test/integration/private_zonal_with_networking/apply.go:34
        	            				/workspace/test/integration/private_zonal_with_networking/terraform.go:397
        	            				/workspace/test/integration/private_zonal_with_networking/terraform.go:407
        	            				/workspace/test/integration/private_zonal_with_networking/terraform.go:431
        	            				/workspace/test/integration/private_zonal_with_networking/stages.go:31
        	            				/workspace/test/integration/private_zonal_with_networking/terraform.go:431
        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; 
        	            	Error: error creating NodePool: googleapi: Error 400: Node_pool_autoscaling.max_node_count and node_pool_autoscaling.total_max_node_count cannot be both set to zero., badRequest
        	            	
        	            	  with module.example.module.gke.google_container_node_pool.pools["default-node-pool"],
        	            	  on ../../../modules/private-cluster/cluster.tf line 383, in resource "google_container_node_pool" "pools":
        	            	 383: resource "google_container_node_pool" "pools" {
        	            	}
        	Test:       	TestPrivateZonalWithNetworking

[Aurelian-Shuttleworth]

Hello, @apeabody ^_^ I meant this PR as a backup for my other PR where the default behaviour is kept. If that approach is not preferred, I will work on fixing the tests so that this version passes code checks and I can remove the draft mark.

[apeabody]

Hi @Aurelian-Shuttleworth with #1562 merged, is this PR still needed? Thanks!

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days