-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nodepool autoscaling vars avail in GKE 1.24.1 result in conflicts. Change default behavior to null #1554
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@Aurelian-Shuttleworth |
Thanks for the contribution @Aurelian-Shuttleworth, here is the int check error message:
|
Hello, @apeabody ^_^ I meant this PR as a backup for my other PR where the default behaviour is kept. If that approach is not preferred, I will work on fixing the tests so that this version passes code checks and I can remove the draft mark. |
23aaac7
to
0846abd
Compare
…ts with zonal limits do not happen.
0846abd
to
f53fbda
Compare
Hi @Aurelian-Shuttleworth with #1562 merged, is this PR still needed? Thanks! |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Changes introduced in feat: add nodepool autoscaling vars avail in GKE 1.24.1 result in conflicts when using total limits.
Currently, google_container_node_pool resource states that total and per zone limits can't be used together.
This change removes the default behaviour where min and max are provided by default if autoscaling is enabled.