-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: promote config_connector_config to ga #1559
feat: promote config_connector_config to ga #1559
Conversation
Tolsee
commented
Feb 7, 2023
- promote configConnectorConfig to ga
- Ref: https://github.com/hashicorp/terraform-provider-google/releases/tag/v4.49.0
/gcbrun |
LGTM and will approve after the integration test passed. Minor: |
a29034c
to
9f6dae9
Compare
@ericyz Updated as per your comment. Thanks! |
/gcbrun |
@bharathkkb Can you please let me know what is the error here? |
/gcbrun |
5 similar comments
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
|
@Tolsee , sorry about the delay. The tests dropped a couple of times, but I have posted the error message in above comment. |
24dbc3c
to
d57285e
Compare
/gcbrun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@apeabody - I might need your help to peer review and merge at your convenience. Thanks |
/gcbrun |
/gcbrun |
6 similar comments
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
…github.com/Tolsee/terraform-google-kubernetes-engine into feat/promote-config_connector_config-to-ga
/gcbrun |
1 similar comment
/gcbrun |
/gcbrun |
…#1559) Co-authored-by: Eric Zhao <zhaoe@google.com> Co-authored-by: Andrew Peabody <andrewpeabody@google.com> Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com> Co-authored-by: Awais Malik <malik.awais@gmail.com>