-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Workload Identity module, to bind roles in various projects for the service account created #1574
feat: Workload Identity module, to bind roles in various projects for the service account created #1574
Changes from 1 commit
5723fb9
932cbdb
a3be7d4
484807b
196dcfb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,7 +85,7 @@ variable "automount_service_account_token" { | |
} | ||
|
||
variable "roles" { | ||
description = "A list of roles to be added to the created service account" | ||
description = "A list of roles to be added to the created service account for specific projects" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Currently this would be a breaking change, if possible can we make this backward compatible. A quick thought might be add a new (optional) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changes are made as mentioned. Pls review |
||
type = list(string) | ||
default = [] | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend using a
map(list(string))
rather than string parsing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with your point.