-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on #1655
fix: add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on #1655
Conversation
…firewall rules toggled on
…s a fw's target tag
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@ericyz @Jberlinsky Could I get some eyes on this? |
Hiya @ericyz and @Jberlinsky can I get some eyes on this? |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
I have been really busy and it's unfortunate that i've missed this being closed... @ericyz and @Jberlinsky if you're too busy to get eyes on this is there another reviewer you can direct me to? This issue is still open. Opened a new PR #1817 |
add_cluster_firewall_rules
,add_master_webhook_firewall_rules
oradd_shadow_firewall_rules
are toggled true.