Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on #1655

Conversation

GorginZ
Copy link
Contributor

@GorginZ GorginZ commented May 31, 2023

@google-cla
Copy link

google-cla bot commented May 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@GorginZ GorginZ changed the title Gke autopilot network tags fix: add cluster_network_tag to autopilot cluster network_tags if firewalls are enabled May 31, 2023
@GorginZ GorginZ changed the title fix: add cluster_network_tag to autopilot cluster network_tags if firewalls are enabled fix: add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on May 31, 2023
@GorginZ GorginZ marked this pull request as ready for review June 4, 2023 06:25
@GorginZ GorginZ requested review from a team, Jberlinsky and ericyz as code owners June 4, 2023 06:25
@GorginZ
Copy link
Contributor Author

GorginZ commented Jul 29, 2023

@ericyz @Jberlinsky Could I get some eyes on this?

@GorginZ
Copy link
Contributor Author

GorginZ commented Sep 6, 2023

Hiya @ericyz and @Jberlinsky can I get some eyes on this?

Copy link

github-actions bot commented Dec 1, 2023

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Dec 1, 2023
@github-actions github-actions bot closed this Dec 9, 2023
@GorginZ
Copy link
Contributor Author

GorginZ commented Dec 14, 2023

I have been really busy and it's unfortunate that i've missed this being closed... @ericyz and @Jberlinsky if you're too busy to get eyes on this is there another reviewer you can direct me to? This issue is still open. Opened a new PR #1817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firewall rules for Autopilot clusters are ineffective
1 participant