-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mesh_certificates support #1712
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -219,6 +219,12 @@ locals { | |
cluster_workload_identity_config = ! local.workload_identity_enabled ? [] : var.identity_namespace == "enabled" ? [{ | ||
workload_pool = "${var.project_id}.svc.id.goog" }] : [{ workload_pool = var.identity_namespace | ||
}] | ||
{% if autopilot_cluster != true %} | ||
cluster_mesh_certificates_config = local.workload_identity_enabled ? [{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Applied readability suggestion - thanks! |
||
enable_certificates = var.enable_mesh_certificates | ||
}] : [] | ||
{% endif %} | ||
|
||
{% if beta_cluster %} | ||
# BETA features | ||
cluster_istio_enabled = ! local.cluster_output_istio_disabled | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -170,6 +170,17 @@ output "identity_namespace" { | |
google_container_cluster.primary | ||
] | ||
} | ||
|
||
{% if autopilot_cluster != true %} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wrapped to fix lint |
||
output "mesh_certificates_config" { | ||
description = "Mesh certificates configuration" | ||
value = local.cluster_mesh_certificates_config | ||
depends_on = [ | ||
google_container_cluster.primary | ||
] | ||
} | ||
{% endif %} | ||
|
||
{% if private_cluster %} | ||
|
||
output "master_ipv4_cidr_block" { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -185,6 +185,9 @@ module "gke" { | |
// We enable Workload Identity by default. | ||
identity_namespace = "${var.project_id}.svc.id.goog" | ||
|
||
// Enabling mesh certificates requires Workload Identity | ||
enable_mesh_certificates = var.enable_mesh_certificates | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please wrap this in {% if autopilot_cluster != true %} so it doesn't render for autopilot clusters. |
||
|
||
authenticator_security_group = var.authenticator_security_group | ||
|
||
enable_shielded_nodes = var.enable_shielded_nodes | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed:
cluster_mesh_certificates_config
no longer in autopilot clusters.