-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for pod_range in private cluster #1803
feat: add support for pod_range in private cluster #1803
Conversation
Thank you for the contribution. Please update the template in the |
c1a7af8
to
a7832ff
Compare
…619/terraform-google-kubernetes-engine into feature/private_network_config
86286a0
to
434c3a7
Compare
…619/terraform-google-kubernetes-engine into feature/private_network_config
@ericyz , please check now. |
/gcbrun |
/gcbrun |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/private-cluster/cluster.tf /tmp/tmp.T3mqCaeXrt/workspace/modules/private-cluster/cluster.tf
Error: submodule's files generation has not been run, please run the |
@ericyz , pls review this, for some reason reruning the |
/gcbrun |
@eric can we merge this, one of the customer is waiting for this |
Thank you for your contribution, this PR helped me a lot. |
…modules#1803) Co-authored-by: Shubham Singh <skshubham@google.com>
Trying to support the ticket id #1802. The ticket required to have pod_range to deploy node_pools to a different range from the cluster.
Adding extra support for placement group as well. These features are available in private-cluster-beta and now supported in GA