-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add enable_l4_ilb_subsetting for autopilot clusters #1969
Conversation
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @kliu47!
Can we confirm this is supported in Autopilot? GKE subsetting is disabled in Autopilot clusters.
https://cloud.google.com/kubernetes-engine/docs/how-to/internal-load-balancing#subsetting
At the very least we should enable in at least one autopilot example so it's exercised by the CI tests: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/examples/simple_autopilot_public/main.tf#L35
@apeabody , Yes, this feature is supported in autopilot clusters, however the default behavior is to have it disabled I've also gone ahead and added the setting to true in the public autopilot example: |
/gcbrun |
/gcbrun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @kliu47!
…google-modules#1969) Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
setting already exists for other submodules. Adding functionality to autopilot submodule