Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch breaking changes #205

Merged
merged 3 commits into from
Jul 3, 2019
Merged

Conversation

aaron-lane
Copy link
Contributor

This branch patches the network policy and CloudRun config implementations so that they are backwards compatible and do not force the recreation of a cluster. A consequence of these changes is that the cloudrun_enabled output is no longer dependent on the clusters as the cloudrun_config argument is omitted in the disabled case which breaks the existing output logic.

Configuring the network policy provider when disabled is invalid.
Explicitly configuring cloudrun_config as disabled is a breaking change
which will recreate the cluster.
Copy link
Contributor

@marko7460 marko7460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaron-lane aaron-lane merged commit 1d64f99 into master Jul 3, 2019
@aaron-lane aaron-lane deleted the aaron-lane-patch-breaking-migration branch July 3, 2019 18:10
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…-modules/aaron-lane-patch-breaking-migration

Patch breaking changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants