Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Can not use dynamic Service Account #27 #225

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Bugfix: Can not use dynamic Service Account #27 #225

merged 2 commits into from
Aug 14, 2019

Conversation

kopachevsky
Copy link
Contributor

@kopachevsky kopachevsky commented Aug 5, 2019

Fixes #27

Added boolean create_service_account variable, true by default, after this change google_service_account.cluster_service_account.count depends on new variable and not on service_account variable, means service_account variable can be dynamic from now on.

Checked following variables combinations

create_service_account service_account result cluster sa generated sa created ?
false "my@sa.com" "my@sa.com" no
true "my@sa.com" "my@sa.com" yes, not used
not defined "my@sa.com" "my@sa.com" yes, not used
false not defined compute default sa no
true not defined autogenerated sa yes
not defined not defined autogenerated sa yes
not defined "create" autogenerated sa yes
true "create" autogenerated sa yes
false "create" compute default sa googleapi: Error 400: Service account "create" is not valid

Added boolean create_service_account variable, true by default, after this change google_service_account.cluster_service_account.count depends on new variable and not on service_account variable, means service_account variable can be dynamic from now on.
modules/private-cluster/sa.tf Show resolved Hide resolved
modules/beta-public-cluster/sa.tf Show resolved Hide resolved
modules/beta-private-cluster/sa.tf Show resolved Hide resolved
autogen/sa.tf Show resolved Hide resolved
@morgante morgante marked this pull request as ready for review August 14, 2019 01:23
@morgante morgante merged commit ed58124 into terraform-google-modules:master Aug 14, 2019
@morgante morgante mentioned this pull request Aug 14, 2019
3 tasks
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…27/dynamic-sa

Bugfix: Can not use dynamic Service Account terraform-google-modules#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not use dynamic Service Account
4 participants