-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added check for beta feature field istio_enabled #230
Added check for beta feature field istio_enabled #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! It looks pretty good, just needs a type change and to fix merge conflicts.
FYI we have consolidated the zonal and regional resources into a single resource so this PR will need to be rebased. Thanks! |
0250b3a
to
8a6c0e8
Compare
I'm sorry if this is a really stupid question, but why is this happening? it doesn't error out if i swap over to |
@richardmcsong |
@richardmcsong Define, please, version of provider |
…usage export config * Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232) * Fixed `google-beta` provider version
…usage export config * Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232) * Fixed `google-beta` provider version
…usage export config * Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232) * Fixed `google-beta` provider version
…usage export config * Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232) * Fixed `google-beta` provider version
…usage export config * Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232) * Fixed `google-beta` provider version
…usage export config * Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232) * Fixed `google-beta` provider version
* Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232) * Fixed `google-beta` provider version
* Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232) * Fixed `google-beta` provider version
* Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232) * Fixed `google-beta` provider version
* Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232) * Fixed `google-beta` provider version
* Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232) * Fixed `google-beta` provider version
* Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232) * Fixed `google-beta` provider version
* Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232) * Fixed `google-beta` provider version
* Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232)
* Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232)
* Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232)
But it says an EMPTY list of objects, not a list of empty objects. Also, I tried doing |
#238 was merged to provide resource usage export config, but the beta feature checks are still helpful. Can you rebase? |
8a6c0e8
to
0e78ca6
Compare
Finally got a chance to rebase. Noticed the other beta features were already done, just missing the istio one. Also fixed some naming, because it's actually detecting for the disabled flag, not the enabled flag. |
* Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232)
…ster Added check for beta feature field istio_enabled
Some beta feature fields may not be returned by the Google API call that terraform uses.
According to Google Support (Case 20165122), when asked why certain Google API calls don't return
istio_config
orpod_security_policy_config
:Since the terraform provider upstream operates by transpiling the API call into the correct resources, I thought it might be most appropriate to code defensively here and check for the field before trying to access it. Fixes #226
I also added resource_usage_export_config support in this PR (https://www.terraform.io/docs/providers/google/r/container_cluster.html#resource_usage_export_config).