Make workload_identity_config dynamic #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvioneto
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
suggested changes
Aug 17, 2019
kopachevsky
reviewed
Aug 17, 2019
|
@sylvioneto can you please update provider version for ./examples in this PR as well? |
|
Closed temporarily because it requires more tests, which I'm doing right now. I'll reopen once it is done. |
|
Reopening the PR because tests worked successfully. Solution was creating a local |
|
@kopachevsky, @morgante, all changes done. |
morgante
approved these changes
Aug 20, 2019
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Make workload_identity_config dynamic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes workload_identity_config dynamic in the cluster configuration in order to solve the problem reported by @richardmcsong in this PR #234 (review), when a cluster was created without that config and should not prompt any change in the terraform plan.