Update integration tests to use new approach #262

paulpalamarchuk · 2019-09-18T16:21:10Z

Fix Migrate repository to new development and CI process #245
Fixed lint-tests
Backwards compatibility of the generate function
Disabled kitchen test stub-domains-private-local (issue Integration test "stub-domains-private-local" fails, trying to reach internal network #264)
Disabled kitchen tests deploy_service and node_pool (issue Test deploy_service and node_pool fail verification on CI #274)

paulpalamarchuk · 2019-09-19T15:17:41Z

Int test that failed on CI, run locally:

CHANGELOG.md

kopachevsky · 2019-09-20T11:57:53Z

test/setup/iam.tf

+
+locals {
+  int_required_roles = [
+    "roles/owner",


I prefer to do not use wide rolesthat includes other permissions like comute.viewer etc

But it works, I think minimization of permissions is next low-priority task

role removed

It's not removed. Please either fix it or say why you chose not to.

CONTRIBUTING.md

morgante · 2019-09-30T21:28:50Z

Makefile

+	docker run --rm -it \
+                -v $(CURDIR):/workspace \
+                $(REGISTRY_URL)/${DOCKER_IMAGE_DEVELOPER_TOOLS}:${DOCKER_TAG_VERSION_DEVELOPER_TOOLS} \
+                /bin/bash -c 'source /usr/local/bin/task_helper_functions.sh && /workspace/helpers/generate.sh && generate'


Do not source an extra file. This is not necessary, as I explained in chat.

morgante · 2019-09-30T21:41:06Z

build/lint.cloudbuild.yaml

+# limitations under the License.
+
+steps:
+- id: 'lint-pull-image'


We don't want to do this. @aaron-lane I know you had suggested it but I think it's a bad idea. If we split them out like this, we'll have to copy every linting step into every repo and maintain it separately.

morgante · 2019-09-30T21:41:22Z

build/lint.cloudbuild.yaml

+  waitFor: ['lint-pull-image']
+- id: 'lint-terraform'
+  name: 'gcr.io/cloud-foundation-cicd/$_DOCKER_IMAGE_DEVELOPER_TOOLS:$_DOCKER_TAG_VERSION_DEVELOPER_TOOLS'
+  args: ['/bin/bash', '-c', 'source /usr/local/bin/task_helper_functions.sh && source /workspace/helpers/generate.sh && check_terraform']


Don't source custom file.

helpers/generate.sh

morgante · 2019-09-30T21:45:18Z

helpers/generate.sh

+  ./helpers/generate_modules/generate_modules.py
+}
+
+function check_generate() {


Why was this function rewritten to be different from master? I'd like an explanation of why these changes were done.

At the moment we don't have function to generate submodules from autorgen directory in docker-image.

I've changed function find_files (added path ./autogen) to exclude that dir from terraform format checks

morgante · 2019-09-30T21:49:05Z

test/setup/iam.tf

+
+locals {
+  int_required_roles = [
+    "roles/owner",


It's not removed. Please either fix it or say why you chose not to.

test/setup/make_source.sh

morgante · 2019-10-01T20:30:38Z

test/task_helper_functions.sh

+  /workspace/helpers/generate_modules/generate_modules.py
+}
+
+function check_generate() {


@paulpalamarchuk I still don't understand why this differs so much from master. It's not clear to me why this would need to be different from the logic we already have [written](Right, what I don't understand is why the logic for this function is so different from what's currently implemented on master. Instead of needing to ).

@morgante I changed this function to avoid errors on CI, in case of using git-diff to compare files. Error: fatal: not a git repository (or any parent up to mount point /)

Ok it's workable then.

* Fix terraform-google-modules#245 * Fixed lint-tests * Backwards compatibility of the `generate` function * Disabled kitchen test `stub-domains-private-local` (issue terraform-google-modules#264)

…move_tests_to_cloudbuild Update integration tests to use new approach

paulpalamarchuk force-pushed the move_tests_to_cloudbuild branch 8 times, most recently from d3b9180 to 26db278 Compare September 19, 2019 11:22

paulpalamarchuk requested review from ingwarr, ivankorn, kopachevsky and nick4fake September 19, 2019 11:37

aaron-lane added the enhancement New feature or request label Sep 19, 2019

paulpalamarchuk force-pushed the move_tests_to_cloudbuild branch 4 times, most recently from c13d1b6 to 80c5dee Compare September 19, 2019 16:08

ingwarr previously approved these changes Sep 19, 2019

View reviewed changes

paulpalamarchuk dismissed ingwarr’s stale review via 5e604a0 September 19, 2019 18:27

paulpalamarchuk force-pushed the move_tests_to_cloudbuild branch from 80c5dee to 5e604a0 Compare September 19, 2019 18:27

kopachevsky reviewed Sep 20, 2019

View reviewed changes

ingwarr previously approved these changes Sep 21, 2019

View reviewed changes

paulpalamarchuk dismissed ingwarr’s stale review via d9a6bd7 September 23, 2019 05:16

paulpalamarchuk force-pushed the move_tests_to_cloudbuild branch 3 times, most recently from c3532a8 to dd1fae1 Compare September 23, 2019 12:40

ingwarr previously approved these changes Sep 23, 2019

View reviewed changes

paulpalamarchuk dismissed ingwarr’s stale review via 59f3d78 September 24, 2019 11:46

paulpalamarchuk force-pushed the move_tests_to_cloudbuild branch from dd1fae1 to 59f3d78 Compare September 24, 2019 11:46

paulpalamarchuk requested review from kopachevsky and ingwarr September 24, 2019 11:47

kopachevsky previously approved these changes Sep 24, 2019

View reviewed changes

paulpalamarchuk marked this pull request as ready for review September 24, 2019 16:37

paulpalamarchuk requested review from aaron-lane, adrienthebo, Jberlinsky and morgante as code owners September 24, 2019 16:37

ingwarr previously approved these changes Sep 24, 2019

View reviewed changes

morgante self-assigned this Sep 30, 2019

morgante suggested changes Sep 30, 2019

View reviewed changes

paulpalamarchuk dismissed stale reviews from ingwarr and kopachevsky via a571209 October 1, 2019 08:19

paulpalamarchuk force-pushed the move_tests_to_cloudbuild branch 3 times, most recently from 1556a25 to 40a918e Compare October 1, 2019 15:02

morgante reviewed Oct 1, 2019

View reviewed changes

paulpalamarchuk force-pushed the move_tests_to_cloudbuild branch from 40a918e to d966358 Compare October 2, 2019 08:31

Update integration tests to use new approach

f7d2a6c

* Fix terraform-google-modules#245 * Fixed lint-tests * Backwards compatibility of the `generate` function * Disabled kitchen test `stub-domains-private-local` (issue terraform-google-modules#264)

paulpalamarchuk force-pushed the move_tests_to_cloudbuild branch from d966358 to f7d2a6c Compare October 2, 2019 08:44

morgante approved these changes Oct 2, 2019

View reviewed changes

morgante merged commit 81eb717 into terraform-google-modules:master Oct 2, 2019

aaron-lane mentioned this pull request Oct 14, 2019

Incomplete documentation for terraform_docs.sh dependancy #209

Closed

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024

Merge pull request terraform-google-modules#262 from paulpalamarchuk/…

9f00a8f

…move_tests_to_cloudbuild Update integration tests to use new approach

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update integration tests to use new approach #262

Update integration tests to use new approach #262

paulpalamarchuk commented Sep 18, 2019 •

edited

Loading

paulpalamarchuk commented Sep 19, 2019

kopachevsky Sep 20, 2019

ingwarr Sep 21, 2019 •

edited

Loading

paulpalamarchuk Sep 24, 2019

morgante Sep 30, 2019

morgante Sep 30, 2019

paulpalamarchuk Oct 1, 2019

morgante Sep 30, 2019

morgante Sep 30, 2019

paulpalamarchuk Oct 1, 2019

morgante Sep 30, 2019

paulpalamarchuk Oct 1, 2019 •

edited

Loading

morgante Sep 30, 2019

morgante Oct 1, 2019

paulpalamarchuk Oct 2, 2019

morgante Oct 2, 2019

Update integration tests to use new approach #262

Update integration tests to use new approach #262

Conversation

paulpalamarchuk commented Sep 18, 2019 • edited Loading

paulpalamarchuk commented Sep 19, 2019

Choose a reason for hiding this comment

ingwarr Sep 21, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulpalamarchuk Oct 1, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulpalamarchuk commented Sep 18, 2019 •

edited

Loading

ingwarr Sep 21, 2019 •

edited

Loading

paulpalamarchuk Oct 1, 2019 •

edited

Loading