Add submodule to set up ACM #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added standalone ACM submodule, embedded acm to examples/simple_zonal. Fixes #268
* Add dependency on k8s endpoint * Fix lint-tests
Co-Authored-By: Aaron Lane <aarondrewlane@gmail.com>
Add submodule to set up ACM
morgante
requested review from
aaron-lane,
adrienthebo and
Jberlinsky
as code owners
…ate_endpoint is false
morgante
force-pushed
the
feature/acm
branch
from
b92b0c5
to
f8d02c1
Compare
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…-modules/feature/acm Add submodule to set up ACM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains #276
Fixes #268