Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kubernetes dashboard addon #337

Merged
merged 9 commits into from
Nov 21, 2019

Conversation

Shashindran
Copy link
Contributor

@Shashindran Shashindran commented Nov 20, 2019

The Kubernetes Dashboard addon is removed for clusters on GKE.

This causing this error:

Error: "addons_config.0.kubernetes_dashboard": [REMOVED] The Kubernetes Dashboard addon is removed for clusters on GKE.

  on .terraform/modules/gke/terraform-google-modules-terraform-google-kubernetes-engine-ab02f24/modules/private-cluster/cluster.tf line 22, in resource "google_container_cluster" "primary":
  22: resource "google_container_cluster" "primary" {

Fixed by removing the dashboard addon config in cluster.tf and updated main.tf and output.tf.

@Shashindran Shashindran changed the title Removed kubernetes dashboard addon config Remove kubernetes dashboard addon config Nov 20, 2019
@Shashindran Shashindran changed the title Remove kubernetes dashboard addon config Remove kubernetes dashboard addon Nov 20, 2019
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Looks like you also need to regenerate docs (with make generate_docs) to get the linters passing (you can check locally with make docker_test_lint).

@morgante morgante self-assigned this Nov 20, 2019
@morgante morgante merged commit 0ae6777 into terraform-google-modules:master Nov 21, 2019
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants