Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider update 3.3.0 #381

Merged
merged 17 commits into from
Dec 27, 2019
Merged

Provider update 3.3.0 #381

merged 17 commits into from
Dec 27, 2019

Conversation

bharathkkb
Copy link
Member

@bharathkkb bharathkkb commented Dec 15, 2019

Fixes #338

Change List for 3.3.0 upgrade:

  • Remove internal references in locals to google_container_cluster.primary.region
  • Default cluster_ipv4_cidr to null. cluster_ipv4_cidr is used for routes-based clusters and ip_allocation_policy is used for VPC-native clusters
  • ${random_string.suffix.result} where networking 2.0 is used due to inability to use computed values with the new for_each implementation in subnets module

@bharathkkb bharathkkb changed the title [WIP] Test provider update 3.2.0 [WIP] Test provider update 3.3.0 Dec 18, 2019
@morgante
Copy link
Contributor

@bharathkkb What's the latest on this? Do you need anything to complete it?

@bharathkkb
Copy link
Member Author

@morgante working on this currently. 3.3.0 was released today so I am making sure int tests are passing.

@bharathkkb
Copy link
Member Author

@morgante actually we havent released the network module with the commits for relaxing the version constraint. If you could release it that would be awesome.

@bharathkkb bharathkkb changed the title [WIP] Test provider update 3.3.0 Provider update 3.3.0 Dec 19, 2019
@bharathkkb
Copy link
Member Author

@morgante @aaron-lane this should be ready for review

Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharathkkb can you add an upgrade guide since this branch includes breaking changes?

@aaron-lane
Copy link
Contributor

Also, can the fix for #384 be split to a separate pull request so we can get it merged quickly and unblock other pull requests?

@bharathkkb
Copy link
Member Author

bharathkkb commented Dec 23, 2019

@aaron-lane sg I will separate the PRs and add upgrade guide

autogen/versions.tf.tmpl Outdated Show resolved Hide resolved
@morgante morgante assigned morgante and unassigned aaron-lane Dec 26, 2019
@bharathkkb
Copy link
Member Author

@aaron-lane @morgante I dont think there are any breaking changes here as I am now defaulting cluster_ipv4_cidr to null. Previously I had mistakenly removed this but cluster_ipv4_cidr is still used for routes-based clusters.

@morgante morgante merged commit e504301 into terraform-google-modules:master Dec 27, 2019
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…re/provider-update

Provider update 3.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to provider version 3.0.0
3 participants