Fixes pod_security_policy_config type issue #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kri5
requested review from
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
suggested changes
Jan 27, 2020
autogen/main/variables.tf.tmpl
Outdated
| @@ -406,6 +406,7 @@ variable "enable_binary_authorization" { | |||
| } | |||
|
|
|||
| variable "pod_security_policy_config" { | |||
| type = list(map(string)) | |||
There was a problem hiding this comment.
I think an object would be better actually.
Suggested change
| type = list(map(string)) | |
| type = list(object({ enabled = bool })) |
There was a problem hiding this comment.
I just updated the PR accordingly, wasn't sure about how strong the constraint should be :)
This fixes an issue where type defaults to string, and leads to a type error attempting to set the value from outside the module.
morgante
approved these changes
Jan 27, 2020
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…orm-google-modules#408) * Specify type for pod_security_policy_config This fixes an issue where type defaults to string, and leads to a type error attempting to set the value from outside the module. * Generate modules following the changes to pod_security_policy_config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to use the variable pod_security_policy_config, as it has no specified type,
terraform interpret it has string, leading to errors such as
As it expects a list of map, i specified the type accordingly.
I used any for the value type inside the map for future-proof reason.
Feel free to comment!