-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 43: Fix issue with single zone, and update test for the problem. #50
Merged
Jberlinsky
merged 13 commits into
terraform-google-modules:master
from
ogreface:issue_43
Jan 8, 2019
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ab5e1e4
Fix issue with single zone, and add test/example for the problem.
2b0aca1
Merge branch 'master' into issue_43
Jberlinsky fc09822
Remove test, make simple zonal a single zone
1f4dd21
Merge branch 'issue_43' of github.com:ogreface/terraform-google-kuber…
e4345be
Merge branch 'master' into issue_43
morgante 57e8334
Slice is 0 indexed....
911a75e
Merge branch 'issue_43' of github.com:ogreface/terraform-google-kuber…
ca8f15e
Merge branch 'master' of github.com:terraform-google-modules/terrafor…
216d593
Merge branch 'master' into issue_43
Jberlinsky f9cae1a
Merge branch 'master' into issue_43
Jberlinsky a62416e
Merge branch 'master' into issue_43
Jberlinsky 8427c3c
Force default to empty value
8ec5679
Merge branch 'issue_43' of github.com:ogreface/terraform-google-kuber…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the relevant change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own understanding, is the issue
google_container_cluster.zonal_primary.*.additional_zones
sometimes resolves to null instead of a list?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I was able to clarify my understanding back in the bug report in #43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's exactly right. When there's no additional zones, the provider returns null, which breaks that logic.