-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 501: Expose node pool "shielded_instance_config" #506
Issue 501: Expose node pool "shielded_instance_config" #506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
The changes need to made in autogen/main/cluster.tf.tmpl
which is then propagated to all the other modules by running make build
. More details here.
You're welcome I have updated the autogen/main/cluster.tf.tmpl However, running make build run to error: docker run --rm -it I tried executing:
results in another error: 401 Anonymous caller does not have storage.objects.get access to config-management-release/released/latest/config-management-operator.yaml Any advice on this? |
@c0ffeec0der that seems odd, I was able to run it fine from your branch. |
Hey, you're right! Previously i thought to solve it by executing inside the container and came that 401 error. But then, after reading your review, maybe it was just the line /r code. So I browsed around and found this thread: https://stackoverflow.com/questions/11616835/r-command-not-found-bashrc-bash-profile dos2unix command solved the issue and the tool worked! I commited all the changes except for file task_helper_functions.sh, because it was modified by dos2unix tool and might cause problem to other coder using linux/mac if I commited it. But there were some changes on readme.md caused by the tool which I think are not relevant to the changes I made. Please review and let me know your thoughts. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linters are failing, but I will clean up separately.
…onitoring options (terraform-google-modules#506) * Expose node pool shielded_instance_config Co-authored-by: c0feec0der <>
Expose node pool "shielded_instance_config" for module:
Tested for beta-private-cluster-update-variant
![test-result](https://user-images.githubusercontent.com/64681762/80913288-c38d7200-8d6d-11ea-8f0f-94a4cbef1002.jpg)