Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance WI module usability with existing KSA #557

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Conversation

bharathkkb
Copy link
Member

fixes #555

  • Adds kubectl_wrapper
  • Adds overwrite flag for annotate command
  • Update docs

@bharathkkb bharathkkb requested review from Jberlinsky and a team as code owners June 11, 2020 20:23
@bharathkkb
Copy link
Member Author

@morgante WDYT about adding an additional invocation of the WI module in the current example to test the use_existing_ksa control flow?

@morgante
Copy link
Contributor

@morgante WDYT about adding an additional invocation of the WI module in the current example to test the use_existing_ksa control flow?

Good idea, let's add it.

@morgante morgante merged commit cf3273d into master Jun 23, 2020
@bharathkkb bharathkkb deleted the fix-wi-existing-ksa branch June 26, 2020 00:48
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workload identity existing sa iam.gke.io/gcp-service-account overwrite
2 participants