Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set auto_provisioning_defaults.service_account #639

Merged

Commits on Dec 23, 2020

  1. Set auto_provisioning_defaults.service_account

    This sets the Service Account that should be used by node VMs created by
    node auto-provisioning. This should cause the auto-provisioned nodes to
    have the same permissions as the nodes that are manually provisioned.
    dpetersen committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    a2dab75 View commit details
    Browse the repository at this point in the history
  2. Allow overriding oAuth scopes for NAP pools

    The defaults I included come from the scopes I observed in a cluster I
    stood up when no scopes were specified. I am assuming these are GKE
    defaults. This does not match the default scopes for normal node pools
    in this Terraform module, so it may not be the correct choice.
    dpetersen committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    4dc0eb5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0c1c8c8 View commit details
    Browse the repository at this point in the history
  4. Only set auto_provisioning_defaults when enabled

    The API will not reject the defaults, but it also does not save them
    when auto-provisioning is disabled. Which means your plan will
    continually attempt to update the attributes, succeed, and then still
    think they need to be updated.
    dpetersen committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    15b9302 View commit details
    Browse the repository at this point in the history
  5. Regenerate modules.

    dpetersen committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    b83d8d8 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. Fix (hopefully) oauthScopes in matchers.

    I don't expect this to fix the tests, there is still the issue of the
    serviceAccount.
    dpetersen committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    91d98b3 View commit details
    Browse the repository at this point in the history