Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provider cache for lint #641

Merged
merged 4 commits into from
Oct 22, 2020
Merged

feat: Provider cache for lint #641

merged 4 commits into from
Oct 22, 2020

Conversation

bharathkkb
Copy link
Member

@bharathkkb bharathkkb commented Aug 22, 2020 •
edited
Loading

ref: GoogleCloudPlatform/cloud-foundation-toolkit#773
TODO:

  • update inspec tests (due to gemfile update)
  • 12.x image with bundler

@bharathkkb bharathkkb requested review from Jberlinsky and a team as code owners August 22, 2020 22:46
@bharathkkb bharathkkb marked this pull request as draft August 22, 2020 22:46
@bharathkkb bharathkkb mentioned this pull request Oct 15, 2020
Merged
1 task
@bharathkkb bharathkkb marked this pull request as ready for review October 16, 2020 04:45
@bharathkkb bharathkkb changed the title [DRAFT] Test provider cache for lint Provider cache for lint Oct 16, 2020
@comment-bot-dev
Copy link

comment-bot-dev commented Oct 21, 2020 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb
test-cache
8cdf68c 
enable parallel

fix makefile

update image
@bharathkkb
update inspec tests
276aeda
@bharathkkb bharathkkb changed the title Provider cache for lint feat: Provider cache for lint Oct 22, 2020
@bharathkkb
Copy link
Member Author

@morgante this is ready for review

@morgante morgante merged commit c8096a4 into master Oct 22, 2020
@morgante morgante deleted the provider-cache branch October 22, 2020 17:42
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@bharathkkb
chore(ci): Provider cache for lint (terraform-google-modules#641)
8565c8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bharathkkb @comment-bot-dev @morgante