-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable vertical pod autoscaling #642
Enable vertical pod autoscaling #642
Conversation
Thanks for the PR! 🚀
Running terraform fmt
Running terraform validate
terraform_validate .
Error:
Reference to undeclared input variable
on cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/deploy_service
Error:
Reference to undeclared input variable
on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/disable_client_cert
Error:
Reference to undeclared input variable
on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/node_pool
Success!
The configuration is valid.
terraform_validate ./examples/node_pool_update_variant
Error:
Reference to undeclared input variable
on ../../modules/private-cluster-update-variant/cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/node_pool_update_variant_beta
Success!
The configuration is valid.
terraform_validate ./examples/private_zonal_with_networking
Success!
The configuration is valid.
terraform_validate ./examples/regional_private_node_pool_oauth_scopes
Error:
Reference to undeclared input variable
on ../../modules/private-cluster/cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/safer_cluster
Success!
The configuration is valid.
terraform_validate ./examples/safer_cluster_iap_bastion
Success!
The configuration is valid.
terraform_validate ./examples/shared_vpc
Error:
Reference to undeclared input variable
on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/simple_regional
Error:
Reference to undeclared input variable
on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/simple_regional_beta
Success!
The configuration is valid.
terraform_validate ./examples/simple_regional_private
Error:
Reference to undeclared input variable
on ../../modules/private-cluster/cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/simple_regional_private_beta
Success!
The configuration is valid.
terraform_validate ./examples/simple_regional_with_kubeconfig
Error:
Reference to undeclared input variable
on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/simple_regional_with_networking
Error:
Reference to undeclared input variable
on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/simple_zonal_private
Error:
Reference to undeclared input variable
on ../../modules/private-cluster/cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/simple_zonal_with_acm
Error:
Reference to undeclared input variable
on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/simple_zonal_with_asm
Success!
The configuration is valid.
terraform_validate ./examples/simple_zonal_with_hub
Error:
Reference to undeclared input variable
on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/stub_domains
Error:
Reference to undeclared input variable
on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/stub_domains_private
Error:
Reference to undeclared input variable
on ../../modules/private-cluster/cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/stub_domains_upstream_nameservers
Error:
Reference to undeclared input variable
on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/upstream_nameservers
Error:
Reference to undeclared input variable
on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/workload_identity
Success!
The configuration is valid.
terraform_validate ./examples/workload_metadata_config
Success!
The configuration is valid.
terraform_validate ./modules/acm
Success!
The configuration is valid.
terraform_validate ./modules/asm
Success!
The configuration is valid.
terraform_validate ./modules/auth
Success!
The configuration is valid.
terraform_validate ./modules/beta-private-cluster
Success!
The configuration is valid.
terraform_validate ./modules/beta-private-cluster-update-variant
Success!
The configuration is valid.
terraform_validate ./modules/beta-public-cluster
Success!
The configuration is valid.
terraform_validate ./modules/beta-public-cluster-update-variant
Success!
The configuration is valid.
terraform_validate ./modules/binary-authorization
Success!
The configuration is valid.
terraform_validate ./modules/config-sync
Success!
The configuration is valid.
terraform_validate ./modules/hub
Success!
The configuration is valid.
terraform_validate ./modules/k8s-operator-crd-support
Success!
The configuration is valid.
terraform_validate ./modules/private-cluster
Error:
Reference to undeclared input variable
on cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./modules/private-cluster-update-variant
Error:
Reference to undeclared input variable
on cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./modules/safer-cluster
Success!
The configuration is valid.
terraform_validate ./modules/safer-cluster-update-variant
Success!
The configuration is valid.
terraform_validate ./modules/services
Success!
The configuration is valid.
terraform_validate ./modules/workload-identity
Success!
The configuration is valid.
terraform_validate ./test/fixtures/beta_cluster
Success!
The configuration is valid.
terraform_validate ./test/fixtures/deploy_service
Error:
Reference to undeclared input variable
on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/disable_client_cert
Error:
Reference to undeclared input variable
on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/node_pool
Success!
The configuration is valid.
terraform_validate ./test/fixtures/node_pool_update_variant
Error:
Reference to undeclared input variable
on ../../../modules/private-cluster-update-variant/cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/private_zonal_with_networking
Success!
The configuration is valid.
terraform_validate ./test/fixtures/safer_cluster
Success!
The configuration is valid.
terraform_validate ./test/fixtures/safer_cluster_iap_bastion
Success!
The configuration is valid.
terraform_validate ./test/fixtures/sandbox_enabled
Success!
The configuration is valid.
terraform_validate ./test/fixtures/simple_regional
Error:
Reference to undeclared input variable
on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/simple_regional_private
Error:
Reference to undeclared input variable
on ../../../modules/private-cluster/cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/simple_regional_with_kubeconfig
Error:
Reference to undeclared input variable
on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/simple_regional_with_networking
Error:
Reference to undeclared input variable
on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/simple_zonal
Error:
Reference to undeclared input variable
on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/simple_zonal_private
Error:
Reference to undeclared input variable
on ../../../modules/private-cluster/cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/simple_zonal_with_asm
Success!
The configuration is valid.
terraform_validate ./test/fixtures/stub_domains
Error:
Reference to undeclared input variable
on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/stub_domains_private
Error:
Reference to undeclared input variable
on ../../../modules/private-cluster/cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/stub_domains_upstream_nameservers
Error:
Reference to undeclared input variable
on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/upstream_nameservers
Error:
Reference to undeclared input variable
on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
53: enabled =
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/workload_identity
Success!
The configuration is valid.
terraform_validate ./test/fixtures/workload_metadata_config
Success!
The configuration is valid.
terraform_validate ./test/setup
Success!
The configuration is valid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
The changes need to made in autogen/main/cluster.tf.tmpl
which is then propagated to all the other modules by running make build
. More details here.
@kolesnikovIV I see that |
ahh, sorry, missed it. Just updated PR. |
@kolesnikovIV |
yep, PR updated |
Hi @kolesnikovIV |
ahh, @bharathkkb, thank you for advice, just committed. |
Hello, |
@descampsk This still needs to be rebased on |
superseded by #758 |
No description provided.