Enable vertical pod autoscaling

[kolesnikovIV]

No description provided.

[comment-bot-dev]

Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

• ⚠️check_terraform
  Failed Terraform check. More details below.

Running terraform fmt
Running terraform validate
terraform_validate . 
Error: 
Reference to undeclared input variable
 on cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/deploy_service 
Error: 
Reference to undeclared input variable
 on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/disable_client_cert 
Error: 
Reference to undeclared input variable
 on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/node_pool 
Success!
The configuration is valid.
terraform_validate ./examples/node_pool_update_variant 
Error: 
Reference to undeclared input variable
 on ../../modules/private-cluster-update-variant/cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/node_pool_update_variant_beta 
Success!
The configuration is valid.
terraform_validate ./examples/private_zonal_with_networking 
Success!
The configuration is valid.
terraform_validate ./examples/regional_private_node_pool_oauth_scopes 
Error: 
Reference to undeclared input variable
 on ../../modules/private-cluster/cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/safer_cluster 
Success!
The configuration is valid.
terraform_validate ./examples/safer_cluster_iap_bastion 
Success!
The configuration is valid.
terraform_validate ./examples/shared_vpc 
Error: 
Reference to undeclared input variable
 on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/simple_regional 
Error: 
Reference to undeclared input variable
 on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/simple_regional_beta 
Success!
The configuration is valid.
terraform_validate ./examples/simple_regional_private 
Error: 
Reference to undeclared input variable
 on ../../modules/private-cluster/cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/simple_regional_private_beta 
Success!
The configuration is valid.
terraform_validate ./examples/simple_regional_with_kubeconfig 
Error: 
Reference to undeclared input variable
 on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/simple_regional_with_networking 
Error: 
Reference to undeclared input variable
 on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/simple_zonal_private 
Error: 
Reference to undeclared input variable
 on ../../modules/private-cluster/cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/simple_zonal_with_acm 
Error: 
Reference to undeclared input variable
 on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/simple_zonal_with_asm 
Success!
The configuration is valid.
terraform_validate ./examples/simple_zonal_with_hub 
Error: 
Reference to undeclared input variable
 on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/stub_domains 
Error: 
Reference to undeclared input variable
 on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/stub_domains_private 
Error: 
Reference to undeclared input variable
 on ../../modules/private-cluster/cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/stub_domains_upstream_nameservers 
Error: 
Reference to undeclared input variable
 on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/upstream_nameservers 
Error: 
Reference to undeclared input variable
 on ../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./examples/workload_identity 
Success!
The configuration is valid.
terraform_validate ./examples/workload_metadata_config 
Success!
The configuration is valid.
terraform_validate ./modules/acm 
Success!
The configuration is valid.
terraform_validate ./modules/asm 
Success!
The configuration is valid.
terraform_validate ./modules/auth 
Success!
The configuration is valid.
terraform_validate ./modules/beta-private-cluster 
Success!
The configuration is valid.
terraform_validate ./modules/beta-private-cluster-update-variant 
Success!
The configuration is valid.
terraform_validate ./modules/beta-public-cluster 
Success!
The configuration is valid.
terraform_validate ./modules/beta-public-cluster-update-variant 
Success!
The configuration is valid.
terraform_validate ./modules/binary-authorization 
Success!
The configuration is valid.
terraform_validate ./modules/config-sync 
Success!
The configuration is valid.
terraform_validate ./modules/hub 
Success!
The configuration is valid.
terraform_validate ./modules/k8s-operator-crd-support 
Success!
The configuration is valid.
terraform_validate ./modules/private-cluster 
Error: 
Reference to undeclared input variable
 on cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./modules/private-cluster-update-variant 
Error: 
Reference to undeclared input variable
 on cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./modules/safer-cluster 
Success!
The configuration is valid.
terraform_validate ./modules/safer-cluster-update-variant 
Success!
The configuration is valid.
terraform_validate ./modules/services 
Success!
The configuration is valid.
terraform_validate ./modules/workload-identity 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/beta_cluster 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/deploy_service 
Error: 
Reference to undeclared input variable
 on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/disable_client_cert 
Error: 
Reference to undeclared input variable
 on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/node_pool 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/node_pool_update_variant 
Error: 
Reference to undeclared input variable
 on ../../../modules/private-cluster-update-variant/cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/private_zonal_with_networking 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/safer_cluster 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/safer_cluster_iap_bastion 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/sandbox_enabled 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/simple_regional 
Error: 
Reference to undeclared input variable
 on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/simple_regional_private 
Error: 
Reference to undeclared input variable
 on ../../../modules/private-cluster/cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/simple_regional_with_kubeconfig 
Error: 
Reference to undeclared input variable
 on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/simple_regional_with_networking 
Error: 
Reference to undeclared input variable
 on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/simple_zonal 
Error: 
Reference to undeclared input variable
 on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/simple_zonal_private 
Error: 
Reference to undeclared input variable
 on ../../../modules/private-cluster/cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/simple_zonal_with_asm 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/stub_domains 
Error: 
Reference to undeclared input variable
 on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/stub_domains_private 
Error: 
Reference to undeclared input variable
 on ../../../modules/private-cluster/cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/stub_domains_upstream_nameservers 
Error: 
Reference to undeclared input variable
 on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/upstream_nameservers 
Error: 
Reference to undeclared input variable
 on ../../../cluster.tf line 53, in resource "google_container_cluster" "primary":
 53:     enabled = 
var.enable_vertical_pod_autoscaling
An input variable with the name "enable_vertical_pod_autoscaling" has not been
declared. This variable can be declared with a variable
"enable_vertical_pod_autoscaling" {} block.
terraform_validate ./test/fixtures/workload_identity 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/workload_metadata_config 
Success!
The configuration is valid.
terraform_validate ./test/setup 
Success!
The configuration is valid.

[bharathkkb]

Thanks for the PR!
The changes need to made in autogen/main/cluster.tf.tmpl which is then propagated to all the other modules by running make build. More details here.

[bharathkkb]

@kolesnikovIV I see that vertical_pod_autoscaling is supported in our beta module, so it would be just a matter of graduating it by moving this and this out of the {% if beta_cluster %}...{% endif %} block and running make build.

[kolesnikovIV]

@kolesnikovIV I see that vertical_pod_autoscaling is supported in our beta module, so it would be just a matter of graduating it by moving this and this out of the {% if beta_cluster %}...{% endif %} block and running make build.

ahh, sorry, missed it. Just updated PR.

[bharathkkb]

@kolesnikovIV vertical_pod_autoscaling is already defined here. IIUC we want to make vertical_pod_autoscaling available in the GA module and for that we would need to remove it from within the {% if beta_cluster %}...{% endif %} blocks.

[kolesnikovIV]

@kolesnikovIV vertical_pod_autoscaling is already defined here. IIUC we want to make vertical_pod_autoscaling available in the GA module and for that we would need to remove it from within the {% if beta_cluster %}...{% endif %} blocks.

yep, PR updated

[bharathkkb]

Hi @kolesnikovIV
Anything I can do to help with this?
I think whats remaining is to move the enable_vertical_pod_autoscaling variable block from the {% if beta_cluster %}...{% endif %} block here.

[kolesnikovIV]

Hi @kolesnikovIV
Anything I can do to help with this?
I think whats remaining is to move the enable_vertical_pod_autoscaling variable block from the {% if beta_cluster %}...{% endif %} block here.

ahh, @bharathkkb, thank you for advice, just committed.

[descampsk]

Hello,
Need help on this ?
I would like to have this feature too !

[morgante]

@descampsk This still needs to be rebased on master, so maybe you could help @kolesnikovIV with that?

[bharathkkb]

superseded by #758