-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!:remove hub from asm module #665
refactor!:remove hub from asm module #665
Conversation
Thanks for the PR! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @cloud-pharaoh
We have this example which is actually an integration test. To keep those passing, I propose we invoke the hub module within that same example.
Another alternative is to use a new test just for hub but I dont think thats necessary as we should be consolidating wherever possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
w00t! |
@cloud-pharaoh one minor nit. The documentation for |
Good catch. I totally forgot there were words in there apart from the variables and outputs :) |
BREAKING CHANGE: GKE Hub functionality has been removed from ASM module(#665). Users can leverage Hub module for this functionality.
BREAKING CHANGE: GKE Hub functionality has been removed from ASM module(#665). Users can leverage Hub module for this functionality.
* remove hub from asm module * fix test * Change membership name to expected name * clean up README.md
BREAKING CHANGE: GKE Hub functionality has been removed from ASM module(terraform-google-modules#665). Users can leverage Hub module for this functionality.
address #661