Promote previously beta features to GA modules #706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko7460
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
|
Thanks for the PR! 🚀 |
marko7460
force-pushed
the
enable-database-encryption
branch
from
4a04ffc
to
f71efc6
Compare
…y_config, and enable_shielded_nodes from beta to GA
marko7460
force-pushed
the
enable-database-encryption
branch
from
f71efc6
to
94e3047
Compare
bharathkkb
reviewed
Oct 9, 2020
There was a problem hiding this comment.
Thanks @marko7460!!
Can we change the source for some of these beta feature tests like Workload Identity so that they point at the GA modules. This way we can have good test coverage on some of these features in GA modules.
|
Yes! I will do that. |
marko7460
force-pushed
the
enable-database-encryption
branch
from
caf55e3
to
c1ab946
Compare
|
@marko7460 you may need to rebase for the service identity fix |
|
@bharathkkb I'm abandoning this PR . I'm switching this work to #709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #644