Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fix #751

Closed
wants to merge 1 commit into from
Closed

Typo fix #751

wants to merge 1 commit into from

Conversation

solomonreal
Copy link

No description provided.

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

  • ⚠️check_terraform
    Failed Terraform check. More details below.
Running terraform fmt
Running terraform validate
terraform_validate . 
Error: 
Reference to undeclared local value
 on cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./examples/deploy_service 
Error: 
Reference to undeclared local value
 on ../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./examples/disable_client_cert 
Error: 
Reference to undeclared local value
 on ../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./examples/node_pool 
Success!
The configuration is valid.
terraform_validate ./examples/node_pool_update_variant 
Success!
The configuration is valid.
terraform_validate ./examples/node_pool_update_variant_beta 
Success!
The configuration is valid.
terraform_validate ./examples/private_zonal_with_networking 
Success!
The configuration is valid.
terraform_validate ./examples/regional_private_node_pool_oauth_scopes 
Success!
The configuration is valid.
terraform_validate ./examples/safer_cluster 
Success!
The configuration is valid.
terraform_validate ./examples/safer_cluster_iap_bastion 
Success!
The configuration is valid.
terraform_validate ./examples/shared_vpc 
Error: 
Reference to undeclared local value
 on ../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./examples/simple_regional 
Error: 
Reference to undeclared local value
 on ../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./examples/simple_regional_beta 
Success!
The configuration is valid.
terraform_validate ./examples/simple_regional_private 
Success!
The configuration is valid.
terraform_validate ./examples/simple_regional_private_beta 
Success!
The configuration is valid.
terraform_validate ./examples/simple_regional_with_kubeconfig 
Error: 
Reference to undeclared local value
 on ../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./examples/simple_regional_with_networking 
Error: 
Reference to undeclared local value
 on ../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./examples/simple_zonal_private 
Success!
The configuration is valid.
terraform_validate ./examples/simple_zonal_with_acm 
Error: 
Reference to undeclared local value
 on ../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./examples/simple_zonal_with_asm 
Error: 
Reference to undeclared local value
 on ../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./examples/simple_zonal_with_hub 
Error: 
Reference to undeclared local value
 on ../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./examples/stub_domains 
Error: 
Reference to undeclared local value
 on ../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./examples/stub_domains_private 
Success!
The configuration is valid.
terraform_validate ./examples/stub_domains_upstream_nameservers 
Error: 
Reference to undeclared local value
 on ../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./examples/upstream_nameservers 
Error: 
Reference to undeclared local value
 on ../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./examples/workload_identity 
Error: 
Reference to undeclared local value
 on ../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./examples/workload_metadata_config 
Success!
The configuration is valid.
terraform_validate ./modules/acm 
Success!
The configuration is valid.
terraform_validate ./modules/asm 
Success!
The configuration is valid.
terraform_validate ./modules/auth 
Success!
The configuration is valid.
terraform_validate ./modules/beta-private-cluster 
Success!
The configuration is valid.
terraform_validate ./modules/beta-private-cluster-update-variant 
Success!
The configuration is valid.
terraform_validate ./modules/beta-public-cluster 
Success!
The configuration is valid.
terraform_validate ./modules/beta-public-cluster-update-variant 
Success!
The configuration is valid.
terraform_validate ./modules/binary-authorization 
Success!
The configuration is valid.
terraform_validate ./modules/config-sync 
Success!
The configuration is valid.
terraform_validate ./modules/hub 
Success!
The configuration is valid.
terraform_validate ./modules/k8s-operator-crd-support 
Success!
The configuration is valid.
terraform_validate ./modules/private-cluster 
Success!
The configuration is valid.
terraform_validate ./modules/private-cluster-update-variant 
Success!
The configuration is valid.
terraform_validate ./modules/safer-cluster 
Success!
The configuration is valid.
terraform_validate ./modules/safer-cluster-update-variant 
Success!
The configuration is valid.
terraform_validate ./modules/services 
Success!
The configuration is valid.
terraform_validate ./modules/workload-identity 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/beta_cluster 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/deploy_service 
Error: 
Reference to undeclared local value
 on ../../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./test/fixtures/disable_client_cert 
Error: 
Reference to undeclared local value
 on ../../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./test/fixtures/node_pool 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/node_pool_update_variant 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/private_zonal_with_networking 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/safer_cluster 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/safer_cluster_iap_bastion 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/sandbox_enabled 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/simple_regional 
Error: 
Reference to undeclared local value
 on ../../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./test/fixtures/simple_regional_private 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/simple_regional_with_kubeconfig 
Error: 
Reference to undeclared local value
 on ../../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./test/fixtures/simple_regional_with_networking 
Error: 
Reference to undeclared local value
 on ../../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./test/fixtures/simple_zonal 
Error: 
Reference to undeclared local value
 on ../../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./test/fixtures/simple_zonal_private 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/simple_zonal_with_asm 
Error: 
Reference to undeclared local value
 on ../../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./test/fixtures/stub_domains 
Error: 
Reference to undeclared local value
 on ../../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./test/fixtures/stub_domains_private 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/stub_domains_upstream_nameservers 
Error: 
Reference to undeclared local value
 on ../../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./test/fixtures/upstream_nameservers 
Error: 
Reference to undeclared local value
 on ../../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./test/fixtures/workload_identity 
Error: 
Reference to undeclared local value
 on ../../../cluster.tf line 62, in resource "google_container_cluster" "primary":
 62:       for_each = 
local.autoscaling_resource_limits
A local value with the name "autoscaling_resource_limits" has not been
declared. Did you mean "autoscalling_resource_limits"?
terraform_validate ./test/fixtures/workload_metadata_config 
Success!
The configuration is valid.
terraform_validate ./test/setup 
Success!
The configuration is valid.

bharathkkb
bharathkkb requested changes Dec 1, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @solomonreal
Thanks for the PR!
The changes need to made in autogen/main/cluster.tf.tmpl which is then propagated to all the other modules by running make build. We also need to update where the local is defined here.

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jan 30, 2021
@github-actions github-actions bot closed this Feb 7, 2021
imphil added a commit to imphil/terraform-google-kubernetes-engine that referenced this pull request Jun 10, 2021
@imphil
Fix typo in local variable
3d2cf58 
autoscalling -> autoscaling

Effectively a complete version of terraform-google-modules#751.
@imphil imphil mentioned this pull request Jun 10, 2021
Merged
morgante pushed a commit that referenced this pull request Jun 10, 2021
@imphil
fix: Fix typo in local variable (#925)
d60eec6 
autoscalling -> autoscaling

Effectively a complete version of #751.
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@imphil
fix: Fix typo in local variable (terraform-google-modules#925)
7693d6f 
autoscalling -> autoscaling

Effectively a complete version of terraform-google-modules#751.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb requested changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@solomonreal @comment-bot-dev @bharathkkb