Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node pool create: add an implicit dependency on parent cluster #77

Merged
merged 6 commits into from
Mar 27, 2019
Merged

Node pool create: add an implicit dependency on parent cluster #77

merged 6 commits into from
Mar 27, 2019

Conversation

JordanP
Copy link
Contributor

@JordanP JordanP commented Jan 31, 2019

The explicit depends_on is not required as there are other ways
to signal to Terraform that a resource depends on another. Implicit
dependencies are more like TF usually operates.

The explicit `depends_on` is not required as there are other ways
to signal to Terraform that a resource depends on another. Implicit
dependencies are more like TF usually operates.
@adrienthebo
Copy link
Contributor

Note for posterity: The integration CI failure appears spurious:

       1 error(s) occurred:
       
       * module.example.module.gke.local.cluster_master_auth_list_layer2: local.cluster_master_auth_list_layer2: At column 40, line 1: list "local.cluster_master_auth_list_layer1" does not have any elements so cannot determine type. in:
       
       ${local.cluster_master_auth_list_layer1[0]}

aaron-lane
aaron-lane previously approved these changes Feb 11, 2019
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JordanP thank you for the contribution!

Copy link
Contributor

@adrienthebo adrienthebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JordanP thanks for making this change! The autogen and root level modules look good, but it doesn't look like this change has propagated to modules/private-cluster. Could you run make generate and see if that updates the private cluster module with the implicit dependency?

@morgante morgante merged commit a9df188 into terraform-google-modules:master Mar 27, 2019
aaron-lane added a commit that referenced this pull request Apr 4, 2019
aaron-lane added a commit that referenced this pull request Apr 4, 2019
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…depends_on

Node pool create: add an implicit dependency on parent cluster
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants