-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cluster labels #81
Conversation
a598929
to
9229f9d
Compare
9229f9d
to
96fe40f
Compare
Passing. Work remaining;
|
96fe40f
to
08d7720
Compare
7bf2b99
to
db9b0d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per in person conversations, let's get test coverage added for this feature.
In addition the documentation changes are causing conflicts, let's reset the documentation to master and handle the docs generation right before merge to avoid more merge conflicts.
add resource_labels param to cluster_regional and zonal resource templates +squash, commit changes from 40d77b7 via make generate best practice +squash - empty map var commit formatting changes from make generate
010ee1c
to
c56aaf0
Compare
bbaace1
to
6238924
Compare
6238924
to
857c04d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emalloy please rebase this branch against master and regenerate the documentation to remove the erroneous git conflict content.
Resolves #65