Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cluster labels #81

Closed
wants to merge 6 commits into from
Closed

Add support for cluster labels #81

wants to merge 6 commits into from

Conversation

emalloy
Copy link
Contributor

@emalloy emalloy commented Feb 13, 2019

Resolves #65

@emalloy emalloy changed the title gke; add support for cluster labels [WIP] add support for cluster labels Feb 13, 2019
@emalloy
Copy link
Contributor Author

emalloy commented Feb 14, 2019

I was able to reproduce the failures in the ci integration-tests, however, when I rebased #80 on to this branch, then I am no longer able to reproduce the failures. Let's get #80 in and this should pass.

@emalloy
Copy link
Contributor Author

emalloy commented Feb 27, 2019

Passing. Work remaining;

  • ensure examples updated
  • tests

@emalloy emalloy changed the title [WIP] add support for cluster labels add support for cluster labels Mar 1, 2019
@adrienthebo adrienthebo changed the title add support for cluster labels [WIP] add support for cluster labels Mar 19, 2019
adrienthebo
adrienthebo suggested changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@adrienthebo adrienthebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per in person conversations, let's get test coverage added for this feature.

In addition the documentation changes are causing conflicts, let's reset the documentation to master and handle the docs generation right before merge to avoid more merge conflicts.

@emalloy
introduce cluster_resource_labels map var
0c07c4d 
add resource_labels param to cluster_regional and zonal resource templates

+squash, commit changes from 40d77b7 via make generate

best practice +squash - empty map var

commit formatting changes from make generate
@emalloy
add cluster_resource_labels var to example instantiations
94aa66e
@emalloy
update docs
9465170
@emalloy emalloy force-pushed the feature/issue_65 branch 5 times, most recently from 010ee1c to c56aaf0 Compare March 25, 2019 18:14
@emalloy emalloy force-pushed the feature/issue_65 branch 7 times, most recently from bbaace1 to 6238924 Compare March 26, 2019 02:03
@aaron-lane aaron-lane changed the title [WIP] add support for cluster labels Add support for cluster labels May 28, 2019
@aaron-lane aaron-lane added the enhancement New feature or request label Jun 3, 2019
aaron-lane
aaron-lane suggested changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emalloy please rebase this branch against master and regenerate the documentation to remove the erroneous git conflict content.

@Dev25 Dev25 mentioned this pull request Jul 19, 2019
Merged
@morgante morgante closed this Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienthebo adrienthebo adrienthebo requested changes

@aaron-lane aaron-lane aaron-lane requested changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

@morgante morgante Awaiting requested review from morgante

Assignees

@emalloy emalloy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for cluster labels
4 participants
@emalloy @adrienthebo @aaron-lane @morgante