-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add support for asm v1.8 to the asm module #824
feat!: Add support for asm v1.8 to the asm module #824
Conversation
kaariger
commented
Feb 17, 2021
•
edited by morgante
Loading
edited by morgante
- Modified default value for asm_version to 1.8
- Modified install_asm.sh wrapper script to call the new install_asm script with the updated flags. Removed flag to for the temp directory, allowing the install_asm script to manage its own temp directory.
- TODO: Need to remove the --enable_cluster_labels flag in the wrapper script once the install_asm script makes that flag optional. It is currently required.
- Added additional IAM bindings and API enablement to the test scripts
- Regenerated docs
- Ran lint - only saw warnings about other files that are unmodified in this change
- Ran integration tests
- Fixes Terraform integration w/ASM script #707
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @kaariger
We can wait for upstream to remove the asmv validate as it will cause a diff on cluster labels if the cluster is managed by TF.
@morgante its a mistake on my part. I should have just updated my original PR. I closed the original PR (my mistake). Please let me know if I should update this PR to make it easier. For future, I will update existing PRs. @bharathkkb it may be ok to wait. However, I had heard that some users were waiting for the module to support 1.8. Don't know if there is any urgent need to allow it as is with the labels added by install_asm script. |
No worries, thanks! Just wanted to confirm if something prompted it.
I'd lean towards adding this sooner rather than later. We can update later. |
Thanks for the PR! 🚀 |
…dded readme for v14.0 release
…e-kubernetes-engine into support-asm-1.8 merging back remote changes
I have committed two more changes:
|
…odules#824) * Initial changes to asm module to support installing asm ver 1.8. * Updated changes to support ASM 1.8 * -updated provider version in the safer_cluster_iap_bastion example -added readme for v14.0 release * -updated readme for v14.0 release Co-authored-by: kaariger <kaariger@users.noreply.github.com> Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>