Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Update CHANGELOG links, add entries for v0.5.0 #84

Closed
wants to merge 6 commits into from

Conversation

adrienthebo
Copy link
Contributor

This commit updates the CHANGELOG.md to include links for versions,
links for pull request entries, separates additions and changes for
the unreleased version, catches up pull request
of 2019-02-28.

@adrienthebo adrienthebo marked this pull request as ready for review March 12, 2019 23:14
@adrienthebo adrienthebo force-pushed the adrienthebo/maint/update-changelog-v0.5.0 branch from 7f2203a to 21daa99 Compare March 20, 2019 23:15
morgante
morgante previously approved these changes Mar 21, 2019
adrienthebo and others added 5 commits March 25, 2019 11:14
This commit updates the CHANGELOG.md to include links for versions,
links for pull request entries, separates additions and changes for
the unreleased version, catches up pull request
of 2019-02-28.
@adrienthebo adrienthebo changed the title Update CHANGELOG links, add entries for v0.5.0 [skip ci] Update CHANGELOG links, add entries for v0.5.0 Mar 25, 2019
@adrienthebo adrienthebo force-pushed the adrienthebo/maint/update-changelog-v0.5.0 branch from 21daa99 to e66adbc Compare March 25, 2019 18:17
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of links for pull requests and issues should be sorted.

CHANGELOG.md Outdated
[#22]: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/22
[#19]: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/19
[#16]: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/16
[#15]: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicated (and an issue).

Suggested change
[#15]: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/15

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in incoming replacement PR.

CHANGELOG.md Outdated
### Added
* Allow creation of service accounts. [#80]
* Add support for private clusters via submodule. [#69]
* Add `remove_default_node_pool` set to `false` by default. Fixes [#15]. [#55]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

55 needs a link.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in replacement PR.

CHANGELOG.md Outdated
* Add `remove_default_node_pool` set to `false` by default. Fixes [#15]. [#55]
* Allow arbitrary key-value pairs to be set on node pool metadata. [#52]
* Add `initial_node_count` parameter to node_pool block. [#60]
* Fix permanent metadata skew due to disable-legacy-endpoints keys [#114]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should move under Fixed. The Added entry should identify the new variable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in replacement PR.

CHANGELOG.md Outdated
### Added
* Allow creation of service accounts. [#80]
* Add support for private clusters via submodule. [#69]
* Add `remove_default_node_pool` set to `false` by default. Fixes [#15]. [#55]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An explanation of what was fixed should go under Fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#15 was a feature request that #55 implemented; I've updated this line to indicate that it's implementing a feature.

CHANGELOG.md Outdated

### Fixed
* Zonal clusters can now accept a single zone. Fixes [#43]. [#50]
* Drop explicit version from simple_zonal example. [#74]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go under Changed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in replacement PR.

thefirstofthe300 added a commit to thefirstofthe300/terraform-google-kubernetes-engine that referenced this pull request Mar 25, 2019
thefirstofthe300 added a commit to thefirstofthe300/terraform-google-kubernetes-engine that referenced this pull request Mar 25, 2019
Copy link
Contributor

@thefirstofthe300 thefirstofthe300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes are addressed in #115

@adrienthebo adrienthebo deleted the adrienthebo/maint/update-changelog-v0.5.0 branch March 25, 2019 20:23
thefirstofthe300 added a commit to thefirstofthe300/terraform-google-kubernetes-engine that referenced this pull request Mar 25, 2019
thefirstofthe300 added a commit to thefirstofthe300/terraform-google-kubernetes-engine that referenced this pull request Mar 25, 2019
thefirstofthe300 added a commit to thefirstofthe300/terraform-google-kubernetes-engine that referenced this pull request Mar 25, 2019
thefirstofthe300 added a commit to thefirstofthe300/terraform-google-kubernetes-engine that referenced this pull request Mar 25, 2019
thefirstofthe300 added a commit to thefirstofthe300/terraform-google-kubernetes-engine that referenced this pull request Mar 25, 2019
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants