-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change service account default to create a new SA per cluster #88
Merged
aaron-lane
merged 14 commits into
aaron-lane-v2.0.0
from
feature/default-to-creating-new-service-account-for-cluster
Apr 5, 2019
Merged
Change service account default to create a new SA per cluster #88
aaron-lane
merged 14 commits into
aaron-lane-v2.0.0
from
feature/default-to-creating-new-service-account-for-cluster
Apr 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienthebo
reviewed
Mar 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soft +1, will switch to hard +1 and merge when CI is green.
Upon closer review I wasn't able to find integration tests verifying the presence of the created service accounts, is this a worthwhile addition? |
de1a787
to
98e8640
Compare
1326847
to
96bb056
Compare
Since this change is breaking, it can't be merged to master as Unreleased; it must be scheduled for v2.0.0.
The ambiguity of what google_container_cluster expects as a value for service_account is not worth addressing in this module.
ab7a251
to
177991a
Compare
morgante
approved these changes
Apr 5, 2019
@Jberlinsky This looks fine to me, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #80