-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all asm_install option #890
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,13 +37,13 @@ variable "location" { | |
variable "gcloud_sdk_version" { | ||
description = "The gcloud sdk version to use. Minimum required version is 293.0.0" | ||
type = string | ||
default = "296.0.1" | ||
default = "337.0.0" | ||
} | ||
|
||
variable "asm_dir" { | ||
description = "Name of directory to keep ASM resource config files." | ||
type = string | ||
default = "asm-dir" | ||
default = "" | ||
} | ||
|
||
variable "service_account_key_file" { | ||
|
@@ -54,11 +54,65 @@ variable "service_account_key_file" { | |
variable "asm_version" { | ||
description = "ASM version to deploy. Available versions are documented in https://github.com/GoogleCloudPlatform/anthos-service-mesh-packages" | ||
type = string | ||
default = "1.8" | ||
default = "1.9" | ||
} | ||
|
||
variable "managed" { | ||
description = "Whether the control plane should be managed." | ||
type = bool | ||
default = false | ||
} | ||
|
||
variable "enable_all" { | ||
description = "Whether you want to enable all asm script option." | ||
type = bool | ||
default = false | ||
} | ||
|
||
variable "enable_cluster_labels" { | ||
description = "Whether the ASM's GKE cluster labels should be added." | ||
type = bool | ||
default = false | ||
} | ||
|
||
variable "enable_cluster_roles" { | ||
description = "Whether the needed cluster roles should be added." | ||
type = bool | ||
default = false | ||
} | ||
|
||
variable "enable_gcp_apis" { | ||
description = "Whether the needed GCP APIs should be activated." | ||
type = bool | ||
default = false | ||
} | ||
|
||
variable "enable_gcp_iam_roles" { | ||
description = "Whether the `resourcemanager.projectIamAdmin` IAM roles should be set." | ||
type = bool | ||
default = false | ||
} | ||
|
||
Comment on lines
+84
to
+95
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have disabled these options as we recommend managing most of these via Terraform and not via the ASM installer script. Generally we should try to use native Terraform resources to manage these as much as possible. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're right but you should let the users choose. Perhaps they had not managed it (or don't want it) with Terraform. When you follow the install_asm documentation, the default examples don't talk about those options and use the "default" installation (without any option). Regards. |
||
variable "enable_gcp_components" { | ||
description = "Whether `workload_identity` and `stackdriver-kubernetes` should be activated." | ||
type = bool | ||
default = false | ||
} | ||
|
||
variable "enable_registration" { | ||
description = "Whether the cluster registration should be managed." | ||
type = bool | ||
default = false | ||
} | ||
|
||
variable "disable_canonical_service" { | ||
description = "Whether the canonical service should be disabled." | ||
type = bool | ||
default = false | ||
} | ||
|
||
variable "custom_overlay_file" { | ||
description = "Path of the custom overlay file." | ||
type = string | ||
default = "" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: breaking change, this will result in delete and recreate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe notice it in the release note ?
Should version change need to execute an upgrade instead ?
We can let "1.8" but we need to explain the risk and the workaround to upgrade or downgrade the version. I didnt try it.