Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated GCP APIs in ASM module #937

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

ameer00
Copy link
Contributor

@ameer00 ameer00 commented Jun 24, 2021

Added mechca.googleapis.com to the set of APIs that need to be enabled for ASM installation.

@ameer00 ameer00 requested review from bharathkkb, Jberlinsky and a team as code owners June 24, 2021 16:38
@bharathkkb bharathkkb changed the title updated GCP APIs in ASM module fix: updated GCP APIs in ASM module Jun 24, 2021
@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb
Copy link
Member

test failure seems unrelated (#936) ASM install was successful.

@bharathkkb bharathkkb merged commit 0c5f363 into terraform-google-modules:master Jun 24, 2021
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Co-authored-by: Ameer Abbas <ameerabbas@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants