Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Hub and ACM submodules to use native Terraform resources #947

Merged
merged 1 commit into from
May 3, 2022
Merged

feat: Update Hub and ACM submodules to use native Terraform resources #947

merged 1 commit into from
May 3, 2022

Conversation

morgante
Copy link
Contributor

@morgante morgante commented Jul 8, 2021 •
edited

Fixes #945.

Note: for now I have left the existing hub module alone so it can be used to register non-GKE clusters.

Unfortunately Hub is not presently able to push out the SSH key to clusters so we still need to have separate resources for that. I'm exploring using the kubernetes provider to do this.

@morgante morgante requested review from bharathkkb, Jberlinsky and a team as code owners July 8, 2021 14:54
@morgante morgante changed the title feat: Update Hub and ACM submodules to use native Terraform resources [WIP] feat: Update Hub and ACM submodules to use native Terraform resources Jul 8, 2021
@morgante morgante mentioned this pull request Sep 8, 2021
Closed
@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 20, 2021
@github-actions github-actions bot closed this Oct 28, 2021
@bharathkkb bharathkkb reopened this Oct 29, 2021
@bharathkkb bharathkkb added triaged Scoped and ready for work and removed Stale labels Oct 29, 2021
@morgante morgante added enhancement New feature or request P2 high priority issues labels Oct 29, 2021
@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Dec 28, 2021
@github-actions github-actions bot closed this Jan 4, 2022
@morgante morgante removed the Stale label Jan 5, 2022
@morgante morgante reopened this Jan 5, 2022
@github-actions
Copy link

github-actions bot commented Mar 6, 2022

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Mar 6, 2022
@github-actions github-actions bot closed this Mar 13, 2022
@bharathkkb bharathkkb reopened this Mar 14, 2022
@github-actions github-actions bot removed the Stale label Mar 14, 2022
@morgante morgante force-pushed the feat/native-acm branch 6 times, most recently from 04ed44c to 4fa1e28 Compare April 18, 2022 20:10
@morgante morgante force-pushed the feat/native-acm branch 4 times, most recently from 4ba1c7c to ccb2b4b Compare April 18, 2022 21:33
@morgante morgante changed the title [WIP] feat: Update Hub and ACM submodules to use native Terraform resources feat: Update Hub and ACM submodules to use native Terraform resources Apr 18, 2022
@morgante
Copy link
Contributor Author

@bharathkkb This should be ready to review.

@morgante morgante force-pushed the feat/native-acm branch 3 times, most recently from 2d9021c to 5875c6b Compare April 18, 2022 22:28
@comment-bot-dev
Copy link

comment-bot-dev commented Apr 18, 2022 •
edited

Thanks for the PR! 🚀
✅ Lint checks have passed.

bharathkkb
bharathkkb reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

docs/upgrading_to_v21.0.md Show resolved Hide resolved
modules/fleet-membership/README.md Show resolved Hide resolved
modules/fleet-membership/outputs.tf Outdated Show resolved Hide resolved
modules/fleet-membership/main.tf Outdated Show resolved Hide resolved
modules/fleet-membership/outputs.tf Outdated Show resolved Hide resolved
modules/hub-acm-feature/creds.tf Outdated Show resolved Hide resolved
modules/hub-acm-feature/main.tf Outdated
project = var.project_id

configmanagement {
version = "1.11.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this result in possibly older versions being installed? We could default to API with a user override for explicit version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's preferable to be explicit with pinning a version here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should expose this as a var defaulting to 1.11.0? I assume users will want to use other versions and it can be toilsome to keep bumping this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd still have to keep bumping the default though. A new variable can always be added in a later (minor) release, but for now I think hard-coding is sensible to keep the API surface small.

modules/hub-acm-feature/outputs.tf Outdated Show resolved Hide resolved
docs/upgrading_to_v21.0.md Show resolved Hide resolved
test/fixtures/simple_zonal/example.tf Show resolved Hide resolved
@morgante morgante force-pushed the feat/native-acm branch 2 times, most recently from 9a41798 to 2a82f24 Compare May 2, 2022 22:52
@morgante morgante mentioned this pull request May 2, 2022
Open
@morgante morgante force-pushed the feat/native-acm branch 3 times, most recently from 388d7ab to 2d762a5 Compare May 3, 2022 00:25
@morgante
Copy link
Contributor Author

morgante commented May 3, 2022

@bharathkkb Ready for another review

@morgante morgante requested a review from bharathkkb May 3, 2022 00:26
@morgante morgante force-pushed the feat/native-acm branch 2 times, most recently from 9d8912a to e577ceb Compare May 3, 2022 01:08
bharathkkb
bharathkkb approved these changes May 3, 2022
View reviewed changes
modules/acm/versions.tf Show resolved Hide resolved
modules/acm/versions.tf Outdated Show resolved Hide resolved
@morgante morgante merged commit 9359961 into master May 3, 2022
@karlkfi karlkfi deleted the feat/native-acm branch May 19, 2022 22:16
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@morgante
feat: Switch to native Terraform resources for hub registration and A…
d268571 
…CM (terraform-google-modules#947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
enhancement New feature or request P2 high priority issues triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace ACM submodule with native resource
3 participants
@morgante @comment-bot-dev @bharathkkb