-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(asm): Adding CA option without providing CA_CERT maps and adding revision_name flag #952
feat(asm): Adding CA option without providing CA_CERT maps and adding revision_name flag #952
Conversation
…t providing the four maps.
adding missed variable in line 207 and 211
correcting REVISION_NAME_COMMAND_SNIPPET variable in line 211
Thanks for the PR! 🚀 |
Ca and rev name
Fixed a missing bracket
… --ca_certs flag, to use self-signed certificate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @christopherhendrich
Some lint related issues #952 (comment) here
I assume we can also remove the bash CA_COMMAND* since with validation only all or none will be allowed?
Hi @bharathkkb, In regards to the CA_COMMAND, do you mean line 182-186 in install_asm.sh? I think that is still needed, because you want to be able to run just the '--ca citadel' flag or the flag and the ca_certs maps or no --ca flag to use meshca. |
…g {} around single digits numbers for line 24-32, adding echos for CA variables.
…aform-google-kubernetes-engine into ca-and-rev-name
…n_name flag (terraform-google-modules#952) * modifying CA config options * Adding flag as an option and adding the ability for to be used without providing the four maps. * adding missed variable in line 207 and 211 * correcting REVISION_NAME_COMMAND_SNIPPET variable in line 211 * updated revision_label process * Made every CA CERTS map its own command snippet * Made every CA CERTS map its own command snippet * testing validations * testing validations * Fixed a missing bracket * Reverting * added revision_name flag and included option to run --ca flag without --ca_certs flag, to use self-signed certificate * Fixed whitespacing * removing another whitespace * ran make build * fixed Error: No newline at end of file ./modules/asm/variables.tf * testing * ran make build * In install_asm.sh: Consolidating IF statement for CA_CERT keys, adding {} around single digits numbers for line 24-32, adding echos for CA variables. Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
This is to align the tf module with the install_asm script as used for Citadel to MeshCA in the official documentation: https://cloud.google.com/service-mesh/docs/ca-migration
It adds the --revision_name flag, so we can deploy a second ASM control plane of the same ASM version using a unique revision name.
It also lets you deploy ASM without specifying the maps for --ca_certs. If you only specify, --ca citadel, it will now deploy successfully.