Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable beta for authenticator_groups_config #989

Conversation

kir4h
Copy link
Contributor

@kir4h kir4h commented Aug 27, 2021

This PR makes authenticator_groups_config available to non beta clusters (through authenticator_security_group variable), since the option is not marked as beta anymore by the upstream provider (https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#private_cluster_config).

@kir4h kir4h requested review from bharathkkb, Jberlinsky and a team as code owners August 27, 2021 16:34
@google-cla
Copy link

google-cla bot commented Aug 27, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kir4h
Copy link
Contributor Author

kir4h commented Aug 27, 2021

@googlebot I signed it!

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@kir4h
Copy link
Contributor Author

kir4h commented Aug 27, 2021

Any chance of getting permissions to check cloud build logs and see what is failing?

@morgante
Copy link
Contributor

Errors look unrelated.

@morgante morgante merged commit 6042fd6 into terraform-google-modules:master Aug 27, 2021
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants