Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Change default balancing_mode to CONNECTION for backends #148

Merged
merged 2 commits into from
Sep 30, 2024
Merged

fix!: Change default balancing_mode to CONNECTION for backends #148

merged 2 commits into from
Sep 30, 2024

Conversation

graham-faulkner-geotab
Copy link
Contributor

@graham-faulkner-geotab graham-faulkner-geotab commented Sep 25, 2024 •
edited by imrannayer
Loading

fix #146

@google-cla Google CLA
Copy link

google-cla bot commented Sep 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pixelandpen pixelandpen mentioned this pull request Sep 25, 2024
Closed
@imrannayer imrannayer changed the title fix: add default balancing_mode - see issue 146 fix!: Change default balancing_mode to CONNECTION for backends Sep 25, 2024
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer self-assigned this Sep 25, 2024
@imrannayer
Copy link
Collaborator

@graham-faulkner-geotab can u plz add docs upgrade to v7 in docs folder and mention that this release is backward incompatible and changes default value of balancing_mode?

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit e26c73a into terraform-google-modules:master Sep 30, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Sep 30, 2024
Open
@imrannayer imrannayer mentioned this pull request Sep 30, 2024
Closed
@graham-faulkner-geotab
Copy link
Contributor Author

thank you @imrannayer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imrannayer imrannayer imrannayer approved these changes

Assignees

@imrannayer imrannayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Balancing Mode for Internal Load Balancer
2 participants
@graham-faulkner-geotab @imrannayer