Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable health check logging #49

Merged
merged 7 commits into from
Apr 12, 2021

Conversation

tnguyen14
Copy link
Contributor

No description provided.

@comment-bot-dev
Copy link

comment-bot-dev commented Apr 1, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

@tnguyen14
Copy link
Contributor Author

I tried using the google-beta provider, but the tests still failed. I am not sure why.

@morgante
Copy link
Contributor

morgante commented Apr 6, 2021

The examples would also need to be updated.

@tnguyen14
Copy link
Contributor Author

@morgante happy to update it once we can get this to work/ tests to pass.

@morgante
Copy link
Contributor

morgante commented Apr 6, 2021

@tnguyen14 This won't pass until the examples are updated, because the tests use the examples.

@tnguyen14
Copy link
Contributor Author

@morgante I tried to update the example, but it's still failing. Is there a way I can look at the error message to figure out what might be wrong?

@morgante
Copy link
Contributor

morgante commented Apr 6, 2021

@tnguyen14 This comment gets updated with the latest results.

@tnguyen14
Copy link
Contributor Author

Test is passing now.

main.tf Outdated Show resolved Hide resolved
tnguyen14 and others added 2 commits April 12, 2021 16:23
Co-authored-by: Morgante Pell <morgante.pell@morgante.net>
@tnguyen14 tnguyen14 requested a review from morgante April 12, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants