feat: adding optional description field to created subnets #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows subnets to optionally be created with a description.
For example:
```
subnets = [
{
subnet_name = "subnet-01"
subnet_ip = "10.10.10.0/24"
subnet_region = "us-west1"
},
{
subnet_name = "subnet-02"
subnet_ip = "10.10.20.0/24"
subnet_region = "us-west1"
subnet_private_access = "true"
subnet_flow_logs = "true"
description = "This subnet has a description"
},
```
tfhartmann
requested review from
aaron-lane,
andreyk-code and
morgante
as code owners
morgante
suggested changes
Sep 6, 2019
README.md
Outdated
| | next_hop_vpn_tunnel | URL to a VpnTunnel that should handle matching packets | string | - | yes | | ||
| | priority | The priority of this route. Priority is used to break ties in cases where there is more than one matching route of equal prefix length. In the case of two routes with equal prefix length, the one with the lowest-numbered priority value wins | string | 1000 | yes | | ||
|
|
||
| The routes list contains maps, where each object represents a route. For the next_hop** inputs, only one is possible to be used in each route. Having two next_hop** inputs will produce an error. Each map has the following inputs (please see examples folder for additional references): |
There was a problem hiding this comment.
It looks like you might have some sort of markdown autoformatter? Could you restrict the change to adding the description field?
There was a problem hiding this comment.
ahh yeah, thats my IDE, it auto-formats, I'll turn that off and re-commit :)
morgante
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows subnets to optionally be created with a description.
For example: