Skip to content
This repository has been archived by the owner on Aug 6, 2022. It is now read-only.

Initial import of fetching a secret #2

Merged
merged 34 commits into from
Jan 16, 2019

Conversation

ogreface
Copy link
Contributor

No description provided.

@morgante morgante self-requested a review December 19, 2018 21:44
@ogreface ogreface changed the title (WIP) Initial import of fetching a secret Initial import of fetching a secret Dec 26, 2018
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first pass. My main feedback is to try to converge this more with the conventions from other modules (ex. the GKE module).

.gitignore Outdated Show resolved Hide resolved
.kitchen.yml Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
secret-infrastructure/README.md Outdated Show resolved Hide resolved
secret-infrastructure/infra/README.md Outdated Show resolved Hide resolved
secret-infrastructure/infra/scripts/clear-secret.sh Outdated Show resolved Hide resolved
secret-infrastructure/main.tf Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
@ogreface
Copy link
Contributor Author

@morgante Ready for a 2nd pass!

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few small items.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
morgante and others added 3 commits January 4, 2019 11:06
Co-Authored-By: ogreface <rishi@rishim.com>
Co-Authored-By: ogreface <rishi@rishim.com>
@ogreface
Copy link
Contributor Author

ogreface commented Jan 4, 2019

@morgante Made the 2nd pass changes.

@morgante morgante merged commit aa4af51 into terraform-google-modules:master Jan 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants