Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service account display name is hard coded. Can we make it a variable? #18

Closed
imrannayer opened this issue Mar 25, 2020 · 1 comment · Fixed by #19
Closed

Service account display name is hard coded. Can we make it a variable? #18

imrannayer opened this issue Mar 25, 2020 · 1 comment · Fixed by #19
Labels
enhancement New feature or request good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work

Comments

@imrannayer
Copy link

Service account display name is hard coded. Is it possible to change it to a variable?

display_name = "Terraform-managed service account"
@morgante
Copy link
Contributor

This seems like a reasonable feature addition. Happy to accept a PR.

@morgante morgante added enhancement New feature or request good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work labels Mar 25, 2020
@schostin schostin mentioned this issue Apr 14, 2020
Merged
morgante pushed a commit that referenced this issue Apr 29, 2020
@schostin
feat: Add support for custom display_name and description #18 (#19)
badaaf3 
* Resolves #18

Added support for display_name and description when creating the service acocunts.

* Upped provider version in examples to latest version, since version 2.7.0 of google provider did not support description field.
@release-please release-please bot mentioned this issue Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for custom display_name and description #18
2 participants
@morgante @imrannayer