Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add Password Validation Policy to Postgres Module #376

Merged
merged 15 commits into from
Jan 5, 2023

Conversation

cleibl
Copy link
Contributor

@cleibl cleibl commented Nov 22, 2022

This PR adds support for the settings.password_validation_policy block in the PostgreSQL Module (https://cloud.google.com/sql/docs/postgres/built-in-authentication#instance_password_policies)

The Password Validation Policy is added as a dynamic block in the PostgreSQL module and is set to null by default to avoid conflicts with other modules.

I've added the password_validation_policy block (and related tests) to the postgres-public-iam example.

Integration Tests and Linting were performed and passed locally.

@google-cla
Copy link

google-cla bot commented Nov 22, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @cleibl! A few quick items:

Thanks!

@apeabody apeabody changed the title Add Password Validation Policy to Postgres Module feat!: Add Password Validation Policy to Postgres Module Nov 30, 2022
@apeabody apeabody self-assigned this Nov 30, 2022
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after @apeabody's comments. It would also be good to add an upgrade guide and also expose this for mysql/mssql modules if supported.

@cleibl cleibl requested a review from a team as a code owner December 19, 2022 18:31
@cleibl cleibl requested review from apeabody and bharathkkb and removed request for apeabody and bharathkkb December 28, 2022 02:08
@cleibl
Copy link
Contributor Author

cleibl commented Dec 28, 2022

Thanks for the comments, issues should be resolved now.

I would love to get all modules but only have time to PR changes for the Postgres updates

@apeabody apeabody removed their assignment Jan 3, 2023
@apeabody
Copy link
Contributor

apeabody commented Jan 3, 2023

Thanks @cleibl! - My comments have been addressed.

Hi @bharathkkb - Does this need an update guide?

@bharathkkb
Copy link
Member

@apeabody since this is a new var with a null default we should be good to go

@bharathkkb bharathkkb merged commit 562455b into terraform-google-modules:master Jan 5, 2023
@comment-bot-dev
Copy link

@cleibl
Thanks for the PR! 🚀
✅ Lint checks have passed.

anuhyapolisetti added a commit to anuhyapolisetti/terraform-google-sql-db that referenced this pull request Mar 13, 2023
g-awmalik added a commit to anuhyapolisetti/terraform-google-sql-db that referenced this pull request Mar 16, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants