-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add Password Validation Policy to Postgres Module #376
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @cleibl! A few quick items:
- Should this also be set to
true
? https://github.com/cleibl/terraform-google-sql-db/blob/master/modules/postgresql/main.tf#L201 - It appears
password_validation_policy
is new in TPG4.33.0
, please bump4.28.0
to4.33.0
here: https://github.com/cleibl/terraform-google-sql-db/blob/master/modules/postgresql/versions.tf#L30
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after @apeabody's comments. It would also be good to add an upgrade guide and also expose this for mysql/mssql modules if supported.
Thanks for the comments, issues should be resolved now. I would love to get all modules but only have time to PR changes for the Postgres updates |
Thanks @cleibl! - My comments have been addressed. Hi @bharathkkb - Does this need an update guide? |
@apeabody since this is a new var with a null default we should be good to go |
@cleibl |
This PR adds support for the settings.password_validation_policy block in the PostgreSQL Module (https://cloud.google.com/sql/docs/postgres/built-in-authentication#instance_password_policies)
The Password Validation Policy is added as a dynamic block in the PostgreSQL module and is set to
null
by default to avoid conflicts with other modules.I've added the password_validation_policy block (and related tests) to the
postgres-public-iam
example.Integration Tests and Linting were performed and passed locally.