Feature/add deletion protection option #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ADDED] * Variable into postgresql module to set the deletion_protection parameter. This will ease the destroy process for the GCP managed databases.
[CHANGED] * README.md files now include the new deletion_protection variable.
|
I see that there is an error in the integration tests, but I cannot see the log of the build in GCP. Could you please let me know what is failing to work on it? |
|
Duplicate of #151. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a deletetion_protection variable to all modules. Default value: true.
This will allow a more easy way to delete managed databases. The default value is the same I found in the terraform-provider-google to follow the same behaviour.