Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allocated_ip_range property to CloudSQL modules #277

Merged
merged 6 commits into from
Feb 11, 2022
Merged

Add allocated_ip_range property to CloudSQL modules #277

merged 6 commits into from
Feb 11, 2022

Conversation

srs2210
Copy link
Contributor

@srs2210 srs2210 commented Feb 10, 2022

TL;DR

The allocated_ip_range property was added to google_sql_database_instance resource from Google provider version 4.4.0. Adding this property to Cloud SQL modules will allow users to select a specific allocated range for their private instances.

Issues fixed

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @srs2210
Lets also update the required versions since 4.4+ is necessary

@srs2210
Copy link
Contributor Author

srs2210 commented Feb 10, 2022

Thanks for the PR @srs2210 Lets also update the required versions since 4.4+ is necessary

@bharathkkb
I have updated the minimum required version in versions.tf for all the modules in my PR.
The PR was breaking because make generate_docs was not run. I have fixed this issue and all the checks are passing now.

@comment-bot-dev
Copy link

@srs2210
Thanks for the PR! 🚀
✅ Lint checks have passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IP configuration missing allocated_ip_range property
4 participants