Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Postgres] Adds deletion_policy parameter for google_sql_user and google_sql_database resource. #386

Merged
merged 3 commits into from
Dec 9, 2022
Merged

[Postgres] Adds deletion_policy parameter for google_sql_user and google_sql_database resource. #386

merged 3 commits into from
Dec 9, 2022

Conversation

isaurabhuttam
Copy link
Contributor

@isaurabhuttam isaurabhuttam commented Dec 9, 2022 •
edited
Loading

Added deletion_policy parameter for google_sql_user and google_sql_database resource to fix the following issue: #205

Added it only for postgres module as this is useful for postgres where databases cannot be deleted from the API if there are users other than cloudsqlsuperuser with access.

@isaurabhuttam isaurabhuttam changed the title User/isaurabhuttam/deletion policy Adds deletion_policy parameter for google_sql_user and google_sql_database resource. Dec 9, 2022
@isaurabhuttam isaurabhuttam changed the title Adds deletion_policy parameter for google_sql_user and google_sql_database resource. [Postgres] Adds deletion_policy parameter for google_sql_user and google_sql_database resource. Dec 9, 2022
@isaurabhuttam isaurabhuttam marked this pull request as ready for review December 9, 2022 16:26
@isaurabhuttam isaurabhuttam requested a review from a team as a code owner December 9, 2022 16:26
@comment-bot-dev
Copy link

@isaurabhuttam
Thanks for the PR! 🚀
✅ Lint checks have passed.

g-awmalik
g-awmalik approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g-awmalik g-awmalik merged commit 8ab6e37 into terraform-google-modules:master Dec 9, 2022
@release-please release-please bot mentioned this pull request Dec 9, 2022
Merged
@g-awmalik g-awmalik mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-awmalik g-awmalik g-awmalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaurabhuttam @comment-bot-dev @g-awmalik