fix(backup): backups are not deleted when retained nr of backups >= 20 #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjespers
requested review from
isaurabhuttam,
imrannayer and
a team
as code owners
tjespers
force-pushed
the
fix-old-backups-not-deleted-due-to-pagination
branch
from
bd6a864
to
bf1e04b
Compare
This commit introduces a new module variable: backup_runs_list_max_results this variable is used to control the maximum amount of results that are returned by the googleapis.sqladmin.v1.backupRuns.list API call. By defaul this call only returns 20 results leading to a situation where no old backups will be deleted whenever the desired amount of retained backups exceed this number. Fixes: terraform-google-modules#519
tjespers
force-pushed
the
fix-old-backups-not-deleted-due-to-pagination
branch
from
bf1e04b
to
49ab893
Compare
|
@imrannayer @isaurabhuttam friendly pinging to see if there is anything i can do to help get this PR merged in? |
|
/gcbrun |
g-awmalik
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(backup): backups are not deleted when retained nr of backups >= 20
This commit introduces a new module variable: backup_runs_list_max_results
this variable is used to control the maximum amount of results that are
returned by the googleapis.sqladmin.v1.backupRuns.list API call.
By defaul this call only returns 20 results leading to a situation
where no old backups will be deleted whenever the desired amount of
retained backups exceed this number.
Fixes: #519